I made a Tokyo Night emacs theme, and I need some feedback!

Hey folks. Recently I tried to make a emacs version of the Tokyo Night theme for NeoVim, I think I did an okay job. I am mostly looking for some feedback in how I can improve this theme (my first time writing any custom emacs lisp). All suggestions/criticisms are welcome :D [https://github.com/rawleyfowler/tokyo-theme.el/](https://github.com/rawleyfowler/tokyo-theme.el/)

You have a syntax error in the `eval` of your flle local variables which prevents the package from building properly. This: ;; eval: (when (fboundp 'rainbow-mode (rainbow-mode +1)) Should be: ;; eval: (when (fboundp 'rainbow-mode) (rainbow-mode +1)) You also have some easy-to-fix linter warnings. I suggest turning on flymake-mode in the source buffer or using the `checkdoc` command to fix those. You also need a space between `lexcial-binding:` and the `t` to enable lexical binding for the file.

Thanks! I just pushed an update!

just an excuse to show off your caml skills :p

If anyone wants to make improvements and get a PR in, the modeline is not styled yet, and I have no idea how to do it!

Hey I use Tokyo night all the time. Love it because of the contrasts. But sorry I have to say it :( https://github.com/doomemacs/themes/blob/master/themes/doom-tokyo-night-theme.el Gonna try your theme tommorow regardless

Don't you need doom to use that?

Nop you can use doom themes without doom

The more you know!

[deleted]

looks better than doom-tokyonight

Kudos for OCaml.

Yours is still closes to the original neo I'm theme I think

Tested it out real quick. I like your theme, but if you want this to become more popular, add some instructions on how to use this. e.g.https://github.com/Theory-of-Everything/everforest-emacs#installation