Shidima · 2022-05-19 15:13
I just created my first Emacs package, a major mode for the [Bicep Language](https://github.com/Azure/bicep). I have to say it was quite easy to get to this. The Emacs docs are great and using LSP made it easy to add completion.
The package can be found on [github](https://github.com/christiaan-janssen/bicep-mode)
There is still a lot to do, but for a first version it is usable already.
doolio_ · 2022-05-19 16:37
Good job. Spotted a typo in the README:
> but found out that the was no package for Emacs.
'the' should be 'there'
Shidima · 2022-05-19 16:39
Thanks, I will fix it when I get home!
hale314 · 2022-05-20 03:19
Looking good. Just some minor comments from me.
- `(defvar bicep-mode-hook nil)` is unnecessary. If you call `macroexpand` (or `macrostep-expand`) on the `(define-derived-mode bicep-mode ...)` form, you will see that the hook is taken care of already.
- The command to start the language server should be defined as a variable with `defcustom`. That way, it's easier for others to customize.
Shidima · 2022-05-20 04:08
Thank you for the feedback, I didn't know that about the hook, and will remove it. As for the language server, that is on the todo list, I was just happy I got it to work yesterday :D