reddit / emacs

Flymake module for awesome-tray package

CIAvash · 2022-05-05 10:06
CIAvash · 2022-05-05 10:06
https://github.com/manateelazycat/awesome-tray/
nv-elisp · 2022-05-05 11:46
The `seq-filter` in your `string-join` is unnecessary. `nil` will be ignored by string-join (treated as an empty string). If you're aiming to avoid extra space between nil values, there's probably a better way to iterate/format your data. The idiomatic choice for your boolean variables is to end the name with `-p` (short for predicate). e.g. some-waiting -> waiting-p all-disabled -> disabled-p The `progn` on line 19 is unnecessary. Face names should not end in `face`.
[deleted] · 2022-05-05 11:49
[deleted]
CIAvash · 2022-05-07 06:42
> The seq-filter in your string-join is unnecessary. nil will be ignored by string-join (treated as an empty string). If you're aiming to avoid extra space between nil values, there's probably a better way to iterate/format your data. Used `string-clean-whitespace` instead. > The idiomatic choice for your boolean variables is to end the name with -p (short for predicate). That part was copied from `doom-modeline`, but only `all-disabled` is a `boolean`, changed it to `disabledp`. emacs-lisp-style-guide says `p` for single word and `-p` for multiple words. > The progn on line 19 is unnecessary. That part was also copied from `doom-modeline`, removed it. > Face names should not end in face. I read this in the style guide as well, but saw packages using `-face`, that's why I used face. Removed it.