I decided to create my own Emacs theme - Feedback appreciated

Hey @all, TL;DR: Would appreciate some feedback about my WIP Emacs theme. Link: [https://github.com/qhga/shanty-theme](https://github.com/qhga/shanty-theme) Last week I finally had the time to do one thing that was on my bucket list for quite some time: Write my own Emacs color theme. It is not available on MELPA yet, because I first wanted to ask some fellow Emacs users about their opinion. So far, the one person that also uses Emacs and I know irl thinks it is quite pleasant. But I would appreciate a bit more feedback, so here I am. It is still a WIP so every feedback is very welcome (: For now, I only included packages I use on a regular basis, but I'll try to slowly but surely add dedicated support for more packages (requests welcome). Most of the other packages I know have sane inheritance and could still be usable right now. I am by far not an elisp-pro but I tried my best to provide a dark and a light version without too much duplicate code. If you wanna check it out, here is the link: [https://github.com/qhga/shanty-theme](https://github.com/qhga/shanty-theme) Thanks <3

Havent tested but it looks good. Thanks for sharing.

This is really nice. Good job!

Was prepared to ignore it, but you know.. looks pretty catchy; I may have to try that out (thanks!) You just have to shop around for some nicer fonts though my dude :) (my favorite still being Consolas as a fixed spacing, ideal for coding.)

Thanks (: Appreciate the compliment as well.

Thank you! Oh, actually I modified this font with gdbfed and added a bunch of self drawn icons for my taskbar (lemonbar). I am kinda attached to this font since I started using it 3 years ago and I spent a lot of time evaluating different fonts before that one! Appreciate the nice words about the theme though <3 Actually, the font was one reason I also tried to make a light version of shanty, bc I could never find a light theme that was pleasant to look at with this font...

What font is that? Looks good though.

The font is called Ttyp0. Here is a link: [https://people.mpi-inf.mpg.de/~uwe/misc/uw-ttyp0/](https://people.mpi-inf.mpg.de/~uwe/misc/uw-ttyp0/). I also love this font (:

Thanks (:

looking at shanty light: - comment foreground is extremely low contrast (have to squint to read comments) - strings and builtins have the same color? they both feel "loud". I think only the strings should feel that way - I see boxes around some methods -- is that just for definitions? curious about when it's used (eg it's not on the object name) - consider softening the lines around the blocks in org looks generally pretty nice n cold edit, off topic: we both have projects named gott lol

Hey, thanks for the suggestions you made! * Comment foreground: Yep, good catch! I'll change that to be more legible. * Boxes: are also visible when a function is called. I am still not completely sure how I feel about that and it might change in the future. (It can feel a bit noisy at times) * Builtins/strings: For me strings are in green color and builtins are yellow. (In both versions dark/light). Could you maybe check which exact faces you are referring to and report them (here or as issue on github) Also a screenshot will do. Ty (: * Org-Blocks: That was actually a conscious decision. I fiddled around with those lines a bit and liked the crisp distinction between the inner block and the meta info. But I see what you mean! In the light theme it is a bit over the top! I might change that to be a tat more subtle. Thanks for this suggestion! gott: what is your project all about? Is it also written in go? (: Edit: Adjusted the color used by the comment face and org-block lines for the light theme. Thanks again for the suggestion!

Sweet! Ty

> Boxes: are also visible when a function is called. I am still not completely sure how I feel about that and it might change in the future. (It can feel a bit noisy at times) Oh! that's interesting -- do you know what face that is? > Builtins/strings: For me strings are in green color and builtins are yellow. (In both versions dark/light). Could you maybe check which exact faces you are referring to and report them (here or as issue on github) Also a screenshot will do. Ty (: ahh -- I'm colorblind, so that's why they got mixed up for me. probably fine then, thanks! > Org-Blocks: That was actually a conscious decision. I fiddled around with those lines a bit and liked the crisp distinction between the inner block and the meta info. But I see what you mean! In the light theme it is a bit over the top! I might change that to be a tat more subtle. Thanks for this suggestion! that makes sense -- mostly I was concerned about the mix with window-divider line context (they look very similar). > gott: what is your project all about? Is it also written in go? (: it is! it is a "go toml transformer" and was a project written for learning some go initially. For transparency, I've written most of my "theme opinions" down with my own themes: https://github.com/neeasade/tarps#fishing (really I should scoop them into melpa one day, then I'll share here as well)

> ahh -- I'm colorblind, so that's why they got mixed up for me. probably fine then, thanks! Oh I see! In some future commit I'll try to add some variables to adjust some aspects of the theme. I'll make sure that I add an option to change green to an alternative color that also fits the theme. Thanks for pointing that out The tarp-mcfay-theme looks nice! I like the grey background and the colors really pop. Initially I also wanted to go with smth grey for the light theme but it kinda looked weird with the rest of the palette. (I started with the dark one bc. I rarely use light themes myself) Edit: > Oh! that's interesting -- do you know what face that is? afaik there is only one face that is used for definitions and calls -> `font-lock-function-name-face`

I like this! I especially like how you visually separate space with solid horizontal lines, no gutter along the horizontal lines, but a gutter along the vertical lines. I may try this myself in my own theme. I had never considered making the minibuffer background the same as the status bar and eliminating the line between them, but since you have done this I can see that it makes the whole bottom portion of the screen look like it is all part of a single large status bar, which actually looks pretty nice.

Thanks for your supportive words (: Whats the name of your theme?

I just installed it. Looks great.

Thanks! It's really cool to see that people actually try it out. Really exciting (: Edit: Would be nice if you let me know what you think about the boxes around functions after using it a bit. Because I am still considering removing them if they are too distracting. Ty!

I’ve been in org all day. I‘ll have a look at elisp tomorrow.

No worries! Report back whenever you feel like. Thanks again for checking it out.

I used it all day yesterday. It's a keeper.

Damn, I'm super happy you like it (: Fyi I've pushed an update yesterday that refined some things!

I looked at the screen shots on github and I find comments almost unreadable. The only change I wouldn't mind seeing is a darker background. I'm happy with the version that I have. I should mention that I'm older than dirt and my eyesight isn't what it used to be. I seem to need a lot of contrast.

My theme doesn't have a name, it is just the theme I created for myself which I use everyday.