PR of conflict

I'm working as a backend developer in a large project since 3+ years, I have a colleague who is a Sr backend developer, but I have more skills, especially in this platform that i'm from scratch. We are doing code review, each feature we do, we create a PR, and the other aprove it. Yesterday she asked me for aprove a PR quicly, a bugfix, becouse a frontend developer was blocked by the issue. I aprove and merge it without check. At the nigth (outside working hours), I catch up with some PR from she and other developer I have in charge. And I realised she made a mistake with a bitfield check. I was going to revert the merge and ask for changes, but I decided not do it because the frontend developer needed the patch and I would not block him, so I write an issue and patch the code. Today I recive a message from she like "i didn't like what you did ". After several meets, I call to her for ask why she writed me that. Acording she, I was wrong touching "her code", she accused me for get into her job and make her looks bad. I told her that she was mistaking my intentions but she continue saying that I made her look like an asshole and I only wanted the credit by the commit. I told her that I did not know what to say to her, and that I could not empathize with her because I did not understand what was wrong. In theory i run the backend development of the project, but my inefficiency in dealing with humans stress me. Do you think I was really wrong? am i missing something?

She wants to be recognized as the person who fixed the bug, for her career. There is nothing you can do about this particular situation other than tell her what you did and that you didn't mean anything by it. In the future though, give her ample opportunities to take credit for things, without overloading her. People like that need to be babied and need verification that they are important.

>>49995 > In the future though, give her ample opportunities to take credit for things, without overloading her. Depends on what you're looking for. If you want to stop dealing with this permanently, then move to a new job where you won't be in a situation like this. If it's just a minor annoyance, then follow the quoted advice. > People like that need to be babied and need verification that they are important. No, they're perfectly content to get rich off the sweat of others' backs. i'd bet that OP has been doing most of the work already and the senior dev's getting uneasy about her own performance not measuring up in a way that could put her cushy position at risk. If I were you, OP, I'd be on the hunt for a better gig right now, something where you've got enough pull that you can do your work in peace. But it's usually the sort of people that don't want to shop around that wind up getting exploited like this in the first place. Good luck!

>>49993 You are not wrong. There is no such thing as "her code" in a team project. You simply found a bug in the application and improved it for everyone. You didn't call her out and say she made a mistake. This sort of stuff happens all the time at jobs and she needs to fix her attitude. (Obviously, don't speak so harshly to her in the terms I am using). Maybe bring it up to your manager. He or she might be able to delicately handle it with her in private.

>>49993 You didn't do anything wrong. She's being a crybaby. >>50062 has the right idea IMO, though I would bring the subject up this week (she's had a few days to cool off) before involving a third party since that will invariably escalate the issue. >>49995 Why the hell would you encourage this behavior? There's plenty of weird soykaf you can make allowances for, everybody's different, but strictly adversarial and counterproductive behavior like OP describes is not among them.

imo writing this here shows you're an easy target. Likely you show similar signs at work which is why people will even try soykaf like this in first place. I wouldn't even think about this. In first place its your responsibility the moment you sign it and she asked for it. Your responsibility is not to her feelings but the project going smoothly. The only thing i would consider is that is she starts soykaf like this she's a possible liability in the future.

>>50084 >imo writing this here shows you're an easy target. Likely you show similar signs at work which is why people will even try soykaf like this in first place. Which is meaningless because OP probably cannot change that. So asking for advice is probably the best OP can do to know how to react to such idiocy.

>>50073 frankly I wouldn't oppose it mainly because I don't care enough about my job.

>>50091 Why not? Its just a matter of recognizing it in first place so behavior can be adjusted. A significant mental roadblock is people not considering an option they have available.

>>50096 Assuming OP is on the spectrum (they could just be socially awkward, in which case you're right), there's precious little they can do to just start getting that sort of nonsense. Paying conscious attention and reading up on such things, but that's about it.

>I aprove and merge it without check >Acording she, I was wrong touching "her code" Stack exchange would tell you your process is like kicking dead whales down the beach. I suspect all workplaces are like that though. At my company we just hired several "experts" to clean our process up but so far they just seem to spend all their time dicking around with gantt charts. We have different problems though, mainly nobody wants to make any decisions to make themselves liable for the results so we just have endless meetings on the same topics. Are you Indian? I've been kind of curious if in other parts of the world they have the same sorts of dysfunction. (I'm in USA)

>>49993 First of all. Try to put your words together and only space after 10 sentence periods. Second of all i would avoid the company you work with and go somewhere else. Maybe Freelance for FOSS places like Blender, Godot Engine, even some Emulation places. The reason why i mention this is because corporate structures are usually like this. You either learn to take the relentless petty drama, sociopathic narcissists who are mediocre and have nothing of value stealing ideas from those who are talented and taking credit. Or you go somewhere else where the pay is not as good but you get much more recognition and freedom to do things as you see fit.

>>50105 Only bigger workplaces are like this due to nepotism and ego. I live in America as well and i have been in numerous jobs. I would highly recommend not working for large scale corporations as they really do not see you as anything more than a slave and use outsourcing to gaslight you into working harder and taking abuse. Smaller places are better, FOSS places are better, even small family businesses are better because they value your time and are willing to work with you than to waste time and pull a carrot in front of you expecting to be the bunny that chases it hoping for a promotion and not to be sidelined due to some "restructuring"

>>50108 Are there really small family businesses that do programming? What sort of projects do they do? Is there still a market for making websites or did those drag and drop things kill it? I was kinda thinking after I got tired of this soykaf I'd try to start a one man business installing network equipment or something.

>>50125 Think of it like this Lainanon. There is small businesses and there is also family businesses, both function similarly. Much like how Walmart and Amazon have this absolute monopolistic parity on the market of shopping or how Twitter, Reddit, Youtube and somewhat to an extent 4clover have the parity on Social media conversation. Altchans like 8ch moe, this place are the small industries trying to be not like the failures of the monopolies that existed before they became corrupt. Best thing to do is to start your own industry with a few friends who have business backgrounds and know their stuff and go from there.

>>50092 That's understandable but would be worth including as a footnote imo. Obviously OP cares if they're writing a college essay about this blip of an experience.

>>50154 OP might just be prone to worrying, especially about situations they don't understand nor understand how to respond to.

>>49993 >her there's your problem. women don't belong in the work force.

>>50156 fuarrrkoff, I've seen immature behavior like that at work from men too. That's what happens when people are never told no or taught to behave as children.

>>49995 >She wants to be recognized as the person who fixed the bug, for her career. More like she doesn't want you to embarrass her in front of the whole company by creating a ticket for a tiny thing without even talking to her first. She even fuarrrking told you >she continue saying that I made her look like an asshole and I only wanted the credit by the commit If someone has fuarrrked up then talk to them in private, send a DM or email. Don't go straight to announcing it to the whole company.

>>49993 Yeah you were wrong She might sound silly claiming her career is ruined or whatever, but there are plenty of companies out there that would take introducing a bug as an excuse to block a salary raise or a promotion, etc. Pretty sure that's why she's crying. The issue is not really about credit though. I don't think she's holding a grudge at all but next time tell whoever screwed up they screwed up so you won't get blamed for nonsense like this (or just ask how she wants this to be handled in the future and if you don't like the answer you can compromise) . Teamwork matters.

>>50246 Filing an issue is not "announcing it to the whole company". Issues are meant to document problems in the code so that they get fixed, it's not some kind of hit list.

>>50253 >Filing an issue is not "announcing it to the whole company". Issues are meant to document problems in the code so that they get fixed, it's not some kind of hit list. You are thinking like a programmer. You are not thinking like management. Don't try to apply autistic logic to this problem. Apply office politics.

>>50267 >Apply office politics. Anybody who couples their ego to their work will be upset if you open a ticket and go "haha i found a bug in that code you merged 30 seconds ago lololol". OP is just too autistic to understand why it matters if it didn't happen to him.

>>50270 I more or less understood OP's issue before your post, but now I don't understand it at all. Why is opening an issue and quickly fixing a bug yourself bad, if it's the most convenient course of action for the sake of another developer and the only "problem" is hurting someone's ego? If that person doesn't want their ego hurt, maybe she should try doing a better job, or not place so much self-image on it.

>>50272 >Why is opening an issue and quickly fixing a bug yourself bad All you had to do is send a private massage saying "hey I found this thing what do you think...". Instead of fixing it behind their back and making a permanent public record that all the managers are going to see the next time they have a bug review meeting. >If that person doesn't want their ego hurt, maybe she should try doing a better job Don't play that game, you're the one who didn't review the PR properly.

>>50276 >All you had to do is send a private massage saying "hey I found this thing what do you think...". Wasn't the incident outside of working hours? People often complain about how they're contacted about work-related matters outside of working hours. >you're the one who didn't review the PR properly. I am not OP. Yes, sorry, didn't notice that when reading the opening post. But isn't it then OP's mistake as well, which he is welcome to fix? And the managers are supposed to get angry at OP for not reviewing the PR properly.

>>50278 >Wasn't the incident outside of working hours? You're right the only interpretation of the post you're responding to is that you need to call up the person right away even if it's the middle of the night. Obviously. >But isn't it then OP's mistake as well, which he is welcome to fix? The way code reviews normally work is you point out things you think are problems and then the original author fixes them if they agree. You don't pass the review then fix the bug behind their back and then open a ticket to claim all the credit. If someone did that to OP he wold be angry too.